sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
4 stars 8 forks source link

Y24-190-3: Use API v2 for PlateConversion calls #2010

Closed sdjmchattie closed 1 month ago

sdjmchattie commented 1 month ago

Closes https://github.com/sanger/limber/issues/1818

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.07%. Comparing base (702cf2f) to head (c9e6d80). Report is 4 commits behind head on develop-Y24-190.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop-Y24-190 #2010 +/- ## ================================================ Coverage 78.06% 78.07% ================================================ Files 466 467 +1 Lines 17792 17797 +5 Branches 225 225 ================================================ + Hits 13890 13895 +5 Misses 3900 3900 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/2010/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/2010/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `69.88% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/2010/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.07% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/2010/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.06% <100.00%> (+<0.01%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/2010/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.16% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sdjmchattie commented 1 month ago

When I received the email "@sdjmchattie pushed 0 commits." I couldn't pass up the opportunity to review. All looks good. Definitely worth testing in int-suite (although I see there is a feature test included), but I'm sure you will anyway. 🎸🎵

Yes unfortunately I got confused with my branching and put some commits on this branch that needed to be on a new one for plate_creation. So I removed the commits from this branch and force pushed. Technically it should have said I "pushed -3 commits" 😆