search

sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
4 stars 8 forks source link

Revert "Adding Norm plate after LBB Lib PCR-XP for tracking Beckman normalisation" #2014

Closed dasunpubudumal closed 1 month ago

dasunpubudumal commented 1 month ago

Reverts sanger/limber#1988 because there're some additional changes to be made.

codeclimate[bot] commented 1 month ago

Code Climate has analyzed commit 2b2062a5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 91.1% (0.0% change).

View more on Code Climate.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.95%. Comparing base (3f8c848) to head (2b2062a). Report is 2 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2014 +/- ## ======================================== Coverage 77.95% 77.95% ======================================== Files 463 463 Lines 17711 17711 Branches 225 225 ======================================== Hits 13807 13807 Misses 3902 3902 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/2014/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/2014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `69.66% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/2014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.95% <ø> (ø)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/2014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `77.95% <ø> (ø)` | | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/2014/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.16% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.