sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
4 stars 8 forks source link

Y24-190-3: Use API V2 for Tube queries everywhere #2034

Closed sdjmchattie closed 2 weeks ago

sdjmchattie commented 3 weeks ago

Closes https://github.com/sanger/limber/issues/1818

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.31%. Comparing base (bff2b48) to head (13a5eab). Report is 17 commits behind head on develop-Y24-190.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop-Y24-190 #2034 +/- ## =================================================== - Coverage 78.31% 78.31% -0.01% =================================================== Files 476 476 Lines 18320 18322 +2 Branches 262 262 =================================================== + Hits 14348 14349 +1 - Misses 3970 3971 +1 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/2034/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/2034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `70.62% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/2034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.31% <100.00%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/2034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.31% <100.00%> (-0.01%)` | :arrow_down: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/2034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.16% <100.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.