Open andrewsparkes opened 2 weeks ago
Attention: Patch coverage is 71.42857%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 78.20%. Comparing base (
785f323
) to head (1166fc6
). Report is 45 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
...s/validators/required_number_of_cells_validator.rb | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@KatyTaylor
I think the idea is to remove the current functionality that allows a study override for required_number_of_cells_per_sample_in_pool
.
This would mean this validator is no longer required: app/models/validators/required_number_of_cells_validator.rb
In this PR I have just removed usage of the override in the export files. Removal of the validator should be another small story I think. It's intertwined with the presenter code so not straight forward.
Closes #1983