search

sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
4 stars 8 forks source link

Y24-190: Use api v2 plate everywhere #2061

Open sdjmchattie opened 2 weeks ago

sdjmchattie commented 2 weeks ago

Closes https://github.com/sanger/limber/issues/1818

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code

codecov[bot] commented 19 hours ago

Codecov Report

Attention: Patch coverage is 87.69231% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (a812785) to head (312c948).

Files with missing lines Patch % Lines
app/models/concerns/presenters/extended_csv.rb 0.00% 7 Missing :warning:
.../models/labware_creators/pooled_tubes_by_sample.rb 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop-Y24-190 #2061 +/- ## =================================================== + Coverage 70.09% 78.20% +8.11% =================================================== Files 125 483 +358 Lines 11211 18163 +6952 Branches 262 262 =================================================== + Hits 7858 14204 +6346 - Misses 3351 3957 +606 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/2061/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/2061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `70.09% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/2061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.20% <87.69%> (?)` | | | [push](https://app.codecov.io/gh/sanger/limber/pull/2061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.20% <87.69%> (+8.11%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/2061/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.28% <87.69%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: