search

sanger / limber

A config-driven LIMS built on Sequencescape, primarily for running library preparation pipelines in the laboratory
MIT License
4 stars 8 forks source link

Y24-384 scRNA - adjust pooling for full allowance #2078

Open andrewsparkes opened 2 days ago

andrewsparkes commented 2 days ago

Closes #1992

Changes proposed in this pull request

Adds the calculations to check for full allowance, adjusting number of cells per chip well if needed and storing that value on the destination pool wells for use in creating the driver file for loading the chip plate later.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (2cb2ef4) to head (57fcd22).

Files with missing lines Patch % Lines
...cerns/labware_creators/donor_pooling_calculator.rb 97.22% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## scrna-pooling-calculation-epic #2078 +/- ## ================================================================== + Coverage 77.97% 78.01% +0.04% ================================================================== Files 471 471 Lines 17975 18016 +41 Branches 262 262 ================================================================== + Hits 14016 14056 +40 - Misses 3957 3958 +1 Partials 2 2 ``` | [Flag](https://app.codecov.io/gh/sanger/limber/pull/2078/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | Coverage Δ | | |---|---|---| | [javascript](https://app.codecov.io/gh/sanger/limber/pull/2078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `69.89% <ø> (ø)` | | | [pull_request](https://app.codecov.io/gh/sanger/limber/pull/2078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.01% <97.82%> (+0.04%)` | :arrow_up: | | [push](https://app.codecov.io/gh/sanger/limber/pull/2078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `78.01% <97.82%> (+0.04%)` | :arrow_up: | | [ruby](https://app.codecov.io/gh/sanger/limber/pull/2078/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger) | `91.17% <97.82%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sanger#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: