DPL-875 As PSD we would like to upgrade Samples Extraction to Ruby 3 and Rails 7 so that we keep up to date with our dependencies.

sanger / samples_extraction

MIT License

0 stars 5 forks source link

DPL-875 As PSD we would like to upgrade Samples Extraction to Ruby 3 and Rails 7 so that we keep up to date with our dependencies. #277

Open TWJW-SANGER opened 1 year ago

TWJW-SANGER commented 1 year ago

Describe the Housekeeping As PSD we would like to upgrade Samples Extraction to Ruby 3 and Rails 7 so that we keep up to date with our dependencies.

Blocking issues

Additional context

[ ] Review and update any other dependencies that require updating as part of this process.
[ ] Ensure any existing unit and integration tests pass

KatyTaylor commented 1 year ago

I've put this as large, since Eduardo's having a fair amount of trouble currently upgrading SS to Ruby 3. Hopefully we'll get some learnings from that though!

BenTopping commented 1 month ago

Adjusting this to small since samples extraction is already on ruby 3 at the time this has been picked up and the rails 7 upgrade was straight forward.

BenTopping commented 4 days ago

Maybe not so straightforward 😅

The rails 7 upgrade caused some unreproducible errors in production and I have created the following story to address the problems https://github.com/sanger/samples_extraction/issues/378. The main problem is that samples extraction's test suite is not comprehensive enough to rely on. The relase was yanked so develop and master are back in a 'stable' state but the rails 7 upgrade needs to be re-attempted at some point.