sanger / samples_extraction

MIT License
0 stars 5 forks source link

Y24-183 - Move Sequencescape API v1 calls over to API v2 #335

Open sdjmchattie opened 4 weeks ago

sdjmchattie commented 4 weeks ago

User story

Sequencescape API v1 will be shut down in the near future and has been deprecated for the past 5 years. We should switch usage of the API over to v2, using the already installed json_api_client gem.

Who are the primary contacts for this story

Stuart McHattie

Who is the nominated tester for UAT

PSD

Acceptance criteria

To be considered successful the solution must allow:

Dependencies Any new endpoints required in Sequencescape will have to be created as they are discovered to be missing. A new story should be created under that repository if there are indeed endpoints to create.

Additional context

The calls made during the last two week period are as below, with counts for each endpoint:

sdjmchattie commented 3 weeks ago

Briefly reviewing the code and the list of calls being made to v1, I think we need to start using the PlatePurpose JSON API endpoint that was only created recently. This endpoint might need to be updated to support creating plates and extraction attributes as these are currently not obviously available in SequenceScape. I don't think there are any actual new endpoints to create.