sanger / sequencescape

Web based LIMS
MIT License
80 stars 32 forks source link

GPL-723 BUG: Plate Location Reports in Sequancescape failing with 'Failed to create report: #2949

Open rl15 opened 3 years ago

rl15 commented 3 years ago

Describe the bug GPL-723 | BUG: Plate Location Reports in Sequancescape failing with 'Failed to create report: That selection returns no plates, no report generated.'

RT Ticket Number N/a

To Reproduce Steps to reproduce the behaviour:

  1. Go to page 'http://sequencescape.psd.sanger.ac.uk/location_reports'
  2. Fill in Create a report by selection sections
  1. See error Failed to create report: That selection returns no plates, no report generated.

Expected behaviour What was expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context See slack channel conversation in heron-ss on 28th October

JamesGlover commented 3 years ago

Exception email, with sensitive data anonymised: An URI::InvalidURIError occurred in location_reports#create:

bad URI(is not URI?): "http://labwhere_host/api/locations/AAA DDD EEE FFF"

lib/lab_where_client.rb:26:in `get'


Request:



Session:



Environment:



Backtrace:


lib/lab_where_client.rb:26:in `get'

lib/lab_where_client.rb:165:in `find_by_barcode'

app/models/location_report/location_report_form.rb:121:in `find_labwhere_location'

app/models/location_report/location_report_form.rb:71:in `check_labwhere_location_exists'

app/models/location_report/location_report_form.rb:51:in `save'

app/controllers/location_reports_controller.rb:37:in `block in create'

app/controllers/location_reports_controller.rb:36:in `create'

KatyTaylor commented 3 years ago

Investigation so far:

@rl15 I couldn't access the Slack conversation from 28th Oct you mention in the issue description, because it's too far in the past. Is it possible you selected the wrong Study for the plate barcodes? Can you reproduce the issue now? Thanks!

KatyTaylor commented 3 years ago

Putting 'on hold' for now as couldn't reproduce - see previous comment.

rl15 commented 3 years ago

Contacted James M & Danni on 2nd. James M wrote (Wednesday, 2 December 2020 at 09:20)

I tried using this again on 18/11 and I still had missing data so I reverted to the labwhere tableau report.

KatyTaylor commented 3 years ago

Figured out why this was not working for James M. This is how he was using it:

I was looking to get the locations to inform the team of where the plates are for destruction. As it turns out they don’t need the locations of all the individual plates just the box locations so I don’t think I will need to use this again for this purpose but it is good to check anyway I guess.

For a list of 1000 barcodes he sent me the report only returned 215. This turned out to be because the plates were not in Sequencescape. As this is a Sequencescape page, it will only retrieve the LabWhere location for a plate if it is also in Sequencescape. Response from James confirms this makes sense:

Ah that seems so simple yet never even crossed my mind. The majority of them would probably not be in sequencescape as I was trying to find samples for destruction from the reefers – many of which would not have been processed or uploaded via sentinel.

This would also explain why this page seemed to work fine once before when I was making a list of purely “cherrypicks done” boxes, as all those plates would have been uploaded. It seems so obvious now you mention it but just going by the crawler day in day out my brain was making the assumption that all the data would be there.