sanger / sequencescape

Web based LIMS
MIT License
83 stars 32 forks source link

Y24-221 - Create Sequencescape pages for tag sets #4239

Closed yoldas closed 5 days ago

yoldas commented 1 month ago

User story As PSD, we would like to create a page to link tag groups as tag sets and list the tag sets.

Who are the primary contacts for this story Abdullah, Andrew, Katy, Neil

Who is the nominated tester for UAT PSD

Acceptance criteria To be considered successful the solution must allow:

New Tag Sets:

Tag Set Listing

View Tag Set

Dependencies This story is blocked by the following dependencies:

References This story has a non-blocking relationship with: See links in the parent research story.

Additional context

Update requirements after discussions with users:

KatyTaylor commented 1 month ago

Thoughts:

--> Is this meant to say 'tag set name' ?

yoldas commented 1 month ago

Thoughts:

  • For dual index, set the name automatically. The two boxes could be labelled 'i7' and 'i5', and we can automatically append those suffixes onto the tag set name to create the tag group names.

I have updated the criteria:

yoldas commented 1 month ago
  • I think adapter type will be the same for both i7 and i5, so just one box for that.

Updated now. There should be one box for the adapter type.

yoldas commented 1 month ago
  • Not necessarily MVP, but I think ideally the list and detail pages should show tag sets (rather than groups) too.

I have tried to enhance the existing tag group pages with tag set information and assumed giving the name of the tag set would be enough for a minimal solution. If we create pages for tag sets instead, we can achieve a cleaner solution maybe. In that case, the existing tag group pages need links to the tag set pages instead of just names. I have updated the description now.

yoldas commented 1 month ago

I have updated the story with new tag set page designs. Acceptance Criteria are updated for replacing tag group pages with the new tag set pages.

KatyTaylor commented 1 month ago

Noting down something we mentioned -

If we are replacing the current tag group pages with tag set pages, we have to make sure tag groups always have an associated tag set - otherwise, you will have some orphaned tag groups that you can't access through the UI.

yoldas commented 3 weeks ago

We are no longer proposing the modification of existing tag group pages. We will add pages to create/list/view tag sets that link the existing tag groups.