sanger / sequencescape

Web based LIMS
MIT License
83 stars 32 forks source link

Y24-286 - [BUG] RVI Bait Capture Library Preparation requests not being updated. #4306

Open BenTopping opened 2 weeks ago

BenTopping commented 2 weeks ago

Describe the bug NOTE: The Limber-Htp - RVI - Bait Capture Library submission is being superseded by the RVI Limber-Htp - RVI Bait Capture Library - NovaSeq 6000 paired end sequencing but the issue still applies to both.

The Limber-Htp - RVI - Bait Capture Library submission template creates 2 request groups, Bait Capture Library Preparation, Limber Multiplexing. These requests should update automatically whilst going through the RVI BCL Pipeline in Limber. However the Bait Capture Library Preparation requests are not getting updated.

This does not appear to affect the pipeline but we should fix this so it does get updated correctly and update the existing records so the requests are correctly passed.

Suspected cause The requests should be started during the RVI Cherrypick -> RVI RT plate transfer / bed verification. This is controlled by the transfer request logic here and the transition states in Limber's robot file for this bed verification. However the state update is not getting fired because the RVI RT does not go into the started state.

Acceptance criteria

To Reproduce Steps to reproduce the behaviour:

  1. Run the RVI BCL integration test suite to completion.
  2. Go to the created Limber-Htp - RVI - Bait Capture Library submission
  3. See Bait Capture Library Preparation requests are not started or passed.

Screenshots Screenshot 2024-08-28 at 14 00 35

Additional context This story is a mixture of Limber and Sequencescape work.

You may also be able to forcefully pass the requests without starting them by using Limbers work_completion_request_type.

Contacts Ben T, Andrew S, Katy T.

KatyTaylor commented 2 weeks ago

This may also mean that the library_start events haven't been sent to the Event Warehouse for this pipeline.