search

sanger / sequencescape

Web based LIMS
MIT License
85 stars 33 forks source link

Y24-372 - [BUG] incorrect country_of_origin options #4405

Open neilsycamore opened 2 days ago

neilsycamore commented 2 days ago

When setting a sample's country_of_origin (in a manifest or via the sample edit view) the options "not applicable: control sample" and "not applicable: sample group" are not correct and prevents a sample from being accessioned

The correct options are: "missing: control sample" and "missing: sample group" this is listed in the ERC000011 checklist

These will need changing.

There will be a data migration story required

neilsycamore commented 1 day ago

For context and any testing required: The bug at the moment only affects ENA accessioning service as countryOf_origin is not required by the EGA Snippet from the submission object

"country_of_origin"=>
        #<Accession::TagCountryOfOrigin:0x00007f9c51524708
         @class_name="::Accession::TagCountryOfOrigin",
         @ebi_name=:"geographic_location_(country_and/or_sea)",
         @errors=nil,
         @groups=[:sample_attributes],
         @name="country_of_origin",
         @services=[:ENA],
         @value="not applicable: control sample">