Update Flipper - Githubissues

sanger / sequencescape

Web based LIMS

MIT License

88 stars 33 forks source link

Update Flipper #4489

Open StephenHulme opened 2 weeks ago

StephenHulme commented 2 weeks ago

Flipper was causing dependency lock with Sinatra (see Depfu).

Changes proposed in this pull request

Update Flipper to v1 branch
Add usage details to readme

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
- Check story numbers included
- Check for debug code
- Check version

StephenHulme commented 1 week ago

I can't get the cucumber tests to pass, putting on hold for now. For more details about the migration see: https://github.com/flippercloud/flipper/issues/789 and https://github.com/ualbertalib/jupiter/pull/3348/file For limited pool threads see: https://github.com/flippercloud/flipper/issues/883 My current thinking is it is related to flipper-ui, routing, or the Rails app in some way as the problem doesn't occur in unit tests.