search

sanger / sequencescape

Web based LIMS
MIT License
88 stars 33 forks source link

build: remove Active Resource #4496

Closed StephenHulme closed 1 week ago

StephenHulme commented 2 weeks ago

Related to #4401 #4481

Can anyone confirm that ActiveResource is no longer used in Sequencescape? There's dependency updates, but I don't think it's actually used?

Changes proposed in this pull request

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.47%. Comparing base (e3ba95d) to head (8564efb). Report is 4 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #4496 +/- ## =========================================== - Coverage 86.48% 86.47% -0.02% =========================================== Files 1390 1390 Lines 29819 29819 =========================================== - Hits 25789 25786 -3 - Misses 4030 4033 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StephenHulme commented 2 weeks ago

Seems to have passed int-suite. I'll merge this in unless there are any objections.