search

sanger / stan-core

MIT License
0 stars 2 forks source link

x1128-a as TS (Katy) I would like to be able to add xenium QC comments on the config page #316

Closed seenanair closed 9 months ago

seenanair commented 10 months ago

Small

khelwood commented 10 months ago

@KatyTudor What are Xenium analysis comments? Are they something that already exists in Stan, or a new category we need to create?

sabrine33 commented 10 months ago

@seenanair double checked to backlog and it is about the xenium QC page. I just updated the title

khelwood commented 10 months ago

@sabrine33 The backlog doesn't seem to say that. Where did you find that information?

sabrine33 commented 10 months ago

@seenanair could you reply please ?

seenanair commented 10 months ago

@khelwood , @sabrine33 Sorry, I didn't mean backlog. I was just telling from what I can remember from the planning session as Xenium QC and also it has got comments in it which are missing from config page. So, I was just mentioning that before proceeding, it is good to clarify with Katy/Minal that whether they mean that page.

khelwood commented 10 months ago

Stan-core doesn't treat comment categories differently from each other. If the comments exist in Stan, then as far as the core is concerned, they can be added.

seenanair commented 10 months ago

Stan-core doesn't treat comment categories differently from each other. If the comments exist in Stan, then as far as the core is concerned, they can be added.

Yes, on the client side as well, all comments are treated the same way in config age and are displayed just by passing iteratively through the categories. But, for some reason Xenium QC comments are not displayed in config page

khelwood commented 10 months ago

What are the Xenium QC comments? Are there any? Do we need to add them to the database?

seenanair commented 10 months ago

From Backlog (story x1045) , it says I would like to record end of Xenium run on a new feature called Xenium QC Comments/notes (to be editable on the config page) be able to select multiple - not manditory - per slide and apply all: Run terminated due to objective cleaning error Run terminated due to software error. *Run paused due to error, but Retry permitted completion._

khelwood commented 10 months ago

Those are the QC labware comments, which are already in the config page.

seenanair commented 10 months ago

Yes, you are right. It's the 'QC labware' that's been displayed. In that case, I don't know what that story means. It's better to get it clarified with Katy, I hope.

KatyTudor commented 10 months ago

@khelwood @seenanair ah thanks for finding them, can we change the title on the config page to say Xenium QC comments instead please?