x1222—As TS (Katy) I want the "Released from box location" information in the release file to match the slot location in the storage box, e.g. 1, 2, 3, 4, not A1, B1 for tracking purposes and matching up - Githubissues

sanger / stan-core

MIT License

0 stars 2 forks source link

x1222—As TS (Katy) I want the "Released from box location" information in the release file to match the slot location in the storage box, e.g. 1, 2, 3, 4, not A1, B1 for tracking purposes and matching up #422

Closed khelwood closed 3 months ago

khelwood commented 3 months ago

@KatyTudor This should already work. If it doesn't, please give me a specific example where it doesn't.

KatyTudor commented 3 months ago

@khelwood I thought so but on friday when Jasmine release the boxes there was a mixture or release formats which didn't make sense so thought I best check. #805712

khelwood commented 3 months ago

@KatyTudor In that RT, the file didn't include storage addresses at all, because the labware being released were not in the same storage location. The story x1223 is addressing that change. This story says that addresses are in release files but in the wrong format.

KatyTudor commented 3 months ago

@khelwood it was in one of the releases associated with that ticket, that had very mixed formatting. but can check if it happens again, once x1223 gets done, then we might need to alter the format, if not we can delete/deprecate this story

khelwood commented 3 months ago

@KatyTudor OK I found a scenario in the code where the numerical address would not be saved. I've updated it.

KatyTudor commented 3 months ago

@khelwood thanks for sorting it

KatyTudor commented 3 months ago

@khelwood its still appearing as A1 B1 etc. can it be slot 1, 2, 3 instead?

releases (12).xlsx

khelwood commented 3 months ago

@KatyTudor Those locations don't have a direction set in Storelight, which is what specifies whether numbering goes top to bottom, or left to right etc. Do you want the release logic to assume that, unless otherwise specified, the numbering starts in the top left and goes down each column, left to right?

KatyTudor commented 3 months ago

@khelwood ah ok, Yes for the slide boxes the number goes top left and goes down each column, left to right

khelwood commented 3 months ago

NB Katy has agreed to provide a specification of which locations' directions should be updated.

KatyTudor commented 3 months ago

@khelwood so sorry got distracted with students yesterday:

Storage areas: STO-1315 STO-1B2C STO-14C7 STO-1B1D STO-0677 STO-1500 STO-08EA - slide boxes 1-7 STO-0FB8 STO-0079 STO-1807

khelwood commented 3 months ago

@KatyTudor

I've set the directions on UAT for the following boxes (omitting those that already have a direction):