search

sanger / traction-service

Ruby on Rails exposing a RESTful API for a Long Read LIMS
https://traction.psd.sanger.ac.uk
MIT License
4 stars 5 forks source link

Update rubocop-rails 2.25.1 → 2.26.0 (minor) #1412

Closed depfu[bot] closed 1 week ago

depfu[bot] commented 3 weeks ago

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.25.1 → 2.26.0) · Repo · Changelog

Release Notes

2.26.0

New features

Bug fixes

  • #1335: Fix an error for Rails/BulkChangeTable when the block for change_table is empty. (@earlopain)
  • #1325: Fix an error for Rails/RenderPlainText when the content type is passed as a constant. (@earlopain)
  • #1337: Fix an error for Rails/Validation when passing no arguments. (@earlopain)
  • #1330: Fix an error for Rails/WhereNot when using placeholder without second argument. (@earlopain)
  • #1311: Fix false negatives for Rails/ActionControllerFlashBeforeRender when using implicit render or rescue blocks. (@tldn0718)
  • #1313: Fix false positives for Rails/CompactBlank when using collection.reject!. (@koic)
  • #1319: Fix a false positive for Rails/RedundantPresenceValidationOnBelongsTo when removing presence would leave other non-validation options like allow_blank without validations. (@earlopain)
  • #1306: Make Rails/PluralizationGrammar aware of byte methods. (@earlopain)
  • #1302: Allow params receiver by default for Style/CollectionMethods. (@koic)
  • #1321: Fix an error for Rails/WhereEquals when the second argument is not yet typed (where("foo = ?", )). (@earlopain)

Changes

  • #1308: Change Rails/CompactBlank to handle select(&:present?). (@fatkodima)
  • #1303: Change Rails/IgnoredSkipActionFilterOption to handle multiple callbacks. (@fatkodima)
  • #1199: Make Rails/WhereEquals aware of where.not(...). (@earlopain)
  • #1003: Change Rails/RootPathnameMethods to detect offenses on Dir.[]. (@r7kamura)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 47 commits:

↗️ parallel (indirect, 1.25.1 → 1.26.3) · Repo

Commits

See the full diff on Github. The new version differs by 10 commits:

↗️ parser (indirect, 3.3.4.0 → 3.3.4.2) · Repo · Changelog

Release Notes

3.3.4.1 (from changelog)

API modifications:

  • Bump 3.2 branch to 3.2.5. (#1036) (Ilya Bylich)
  • Bump Racc to 1.8.1 (#1031) (Koichi ITO)

Bugs fixed:

  • builder.rb: catch encoding errors when parsing invalid encoding regexp (#1033) (Earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 11 commits:

↗️ rubocop-ast (indirect, 1.32.0 → 1.32.1) · Repo · Changelog

Release Notes

1.32.1 (from changelog)

Changes

  • #309: Mark RuboCop::AST::EnsureNode as being in a void context. (@earlopain)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 6 commits:

Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.89%. Comparing base (2eb2ab0) to head (9d1f8d0). Report is 11 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1412 +/- ## =========================================== - Coverage 97.89% 97.89% -0.01% =========================================== Files 410 410 Lines 12941 12970 +29 =========================================== + Hits 12669 12697 +28 - Misses 272 273 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.