sanger / unified_warehouse

MIT License
2 stars 9 forks source link

Update rubocop-rails 2.20.2 → 2.21.2 (minor) #558

Closed depfu[bot] closed 1 year ago

depfu[bot] commented 1 year ago

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.20.2 → 2.21.2) · Repo · Changelog

Release Notes

2.21.2

Bug fixes

  • #1126: Fix a false positive for Rails/RedundantActiveRecordAllMethod when using some Enumerable's methods with block argument. (@koic)
  • #1121: Fix an error for Rails/SelectMap when using select(:column_name).map(&:column_name) without receiver model. (@koic)
  • #1119: Fix an incorrect autocorrect for Rails/RedundantActiveRecordAllMethod when all has parentheses. (@masato-bkn)
  • #1130: Fix crash for Rails/UniqueValidationWithoutIndex with bare validate. (@jamiemccarthy)
  • #1124: Fix false positives for Rails/RedundantActiveRecordAllMethod when receiver is not an Active Record model. (@koic)

2.21.1

Bug fixes

  • #1108: Fix an incorrect autocorrect for Rails/TimeZone when using String#to_time. (@koic)
  • #1109: Fix error for Rails/RedundantActiveRecordAllMethod when all is an argument for AR methods. (@masato-bkn)
  • #1110: Fix false positive for Rails/RedundantActiveRecordAllMethod when all has any parameters. (@masato-bkn)

2.21.0

New features

  • #1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). (@koic)
  • #158: Add Rails/DangerousColumnNames cop. (@r7kamura)
  • #1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. (@marocchino)
  • #967: Add new Rails/UnusedRenderContent cop. (@samrjenkins)
  • #1052: Add explicit style to Rails/I18nLazyLookup. (@sunny)
  • #1016: Add new Rails/RedundantActiveRecordAllMethod cop. (@masato-bkn)

Bug fixes

  • #1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. (@vlad-pisanov)
  • #1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. (@koic)
  • #1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. (@r7kamura)
  • #1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. (@koic)
  • #1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. (@ydah)
  • #1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. (@koic)
  • #1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. (@fastjames)
  • #1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. (@fatkodima)
  • #1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. (@nipe0324)

Changes

  • #1056: Fix database adapter detection for nested config. (@mjankowski)
  • #1031: Make Lint/SafeNavigationChain allow presence_in. (@koic)
  • #1080: Make Rails/HttpStatus aware of string number status. (@r7kamura)
  • #1094: Make Rails/TimeZone aware of String#to_time. (@koic)
  • #1015: Make Style/InvertibleUnlessCondition aware of Active Support methods. (@koic)
  • #903: Read database config for Rails/BulkChangeTable from environment variable. (@joergschiller)
  • #1058: Relax Include path for Rails/FindBy and Rails/FindEach. (@koic)
  • #994: Restrict DuplicateAssociation cop to ActiveRecord. (@mjankowski)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.55.1 → 1.56.4) · Repo · Changelog

Release Notes

1.56.4

Bug fixes

  • #12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. (@koic)
  • #12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. (@koic)
  • #12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. (@koic)
  • #12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. (@koic)
  • #12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. (@koic)
  • #12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. (@koic)
  • #12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. (@ydah)
  • #12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. (@koic)

Changes

  • #12197: Make Style/CollectionMethods aware of collect_concat. (@koic)

1.56.3

Bug fixes

  • #12151: Make Layout/EmptyLineAfterGuardClause allow :nocov: directive after guard clause. (@koic)
  • #12195: Fix a false negative for Layout/SpaceAfterNot when a newline is present after !. (@ymap)
  • #12192: Fix a false positive for Layout/RedundantLineBreak when using quoted symbols with a single newline. (@ymap)
  • #12190: Fix a false positive for Layout/SpaceAroundOperators when aligning operators vertically. (@koic)
  • #12171: Fix a false positive for Style/ArrayIntersect when using block argument for Enumerable#any?. (@koic)
  • #12172: Fix a false positive for Style/EmptyCaseCondition when using return, break, next or method call before empty case condition. (@koic)
  • #12162: Fix an error for Bundler/DuplicatedGroup when there's a duplicate set of groups and the group value contains a splat. (@koic)
  • #12182: Fix an error for Lint/UselessAssignment when variables are assigned using chained assignment and remain unreferenced. (@koic)
  • #12181: Fix an incorrect autocorrect for Lint/UselessAssignment when variables are assigned with sequential assignment using the comma operator and unreferenced. (@koic)
  • #12187: Fix an incorrect autocorrect for Style/SoleNestedConditional when comment is in an empty nested if body. (@ymap)
  • #12183: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with safe navigation method call. (@koic)
  • #12168: Fix bug in Style/ArgumentsForwarding when there are repeated send nodes. (@owst)
  • #12185: Set target version for Layout/HeredocIndentation. (@tagliala)

1.56.2

Bug fixes

  • #12138: Fix a false positive for Layout/LineContinuationLeadingSpace when a backslash is part of a multiline string literal. (@ymap)
  • #12155: Fix false positive for Layout/RedundantLineBreak when using a modified singleton method definition. (@koic)
  • #12143: Fix a false positive for Lint/ToEnumArguments when using anonymous keyword arguments forwarding. (@koic)
  • #12148: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using FileUtils.remove_dir, FileUtils.remove_entry, or FileUtils.remove_entry_secure. (@koic)
  • #12141: Fix false positive for Style/ArgumentsForwarding when method def includes additional kwargs. (@owst)
  • #12154: Fix incorrect diagnosticProvider value of LSP. (@koic)

1.56.1

Bug fixes

  • #12136: Fix a false negative for Layout/LeadingCommentSpace when using #+ or #- as they are not RDoc comments. (@koic)
  • #12113: Fix a false positive for Bundler/DuplicatedGroup when groups are duplicated but source, git, platforms, or path values are different. (@koic)
  • #12134: Fix a false positive for Style/MethodCallWithArgsParentheses when parentheses are used in one-line in pattern matching. (@koic)
  • #12111: Fix an error for Bundler/DuplicatedGroup group declaration has keyword option. (@koic)
  • #12109: Fix an error for Style/ArgumentsForwarding cop when forwarding kwargs/block arg and an additional arg. (@ydah)
  • #12117: Fix a false positive for Style/ArgumentsForwarding cop when not always forwarding block. (@owst)
  • #12115: Fix an error for Style/Lambda when using numbered parameter with a multiline -> call. (@koic)
  • #12124: Fix false positives for Style/RedundantParentheses when parentheses in super or yield call with multiline style argument. (@koic)
  • #12120: Fix false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ). (@koic)
  • #12133: Fix Style/RedundantSelfAssignmentBranch to handle heredocs. (@r7kamura)
  • #12105: Fix target ruby Gem::Requirement matcher and version parsing to support multiple version constraints. (@ItsEcholot)

1.56.0

New features

  • #12074: Add new Bundler/DuplicatedGroup cop. (@OwlKing)
  • #12078: Make LSP server support rubocop.formatAutocorrectsAll execute command. (@koic)

Bug fixes

  • #12106: Fix a false negative for Style/RedundantReturn when returning value with guard clause and return is used. (@koic)
  • #12095: Fix a false positive for Style/Alias when EncforcedStyle: prefer_alias and using alias with interpolated symbol argument. (@koic)
  • #12098: Fix a false positive for Style/ClassEqualityComparison when comparing interpolated string class name for equality. (@koic)
  • #12102: Fix an error for Style/LambdaCall when using nested lambda call x.().(). (@koic)
  • #12099: Fix an incorrect autocorrect for Style/Alias when EncforcedStyle: prefer_alias_method and using alias with interpolated symbol argument. (@koic)
  • #12085: Fix an error for Lint/SuppressedException when AllowNil: true is set and endless method definition is used. (@koic)
  • #12087: Fix false positives for Style/ArgumentsForwarding with additional args/kwargs in def/send nodes. (@owst)
  • #12071: Fix Style/SymbolArray false positives when using square brackets or interpolation in a symbol literal in a percent style array. (@jasondoc3)
  • #12061: Support regex in StringLiteralsInInterpolation. (@jonas054)
  • #12091: With --fail-level A ignore non-correctable offenses at :info severity. (@naveg)

Changes

  • #12094: Add base64 gem to runtime dependency to suppress Ruby 3.3's warning. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.18.1 → 5.20.0) · Repo · Changelog

Release Notes

5.20.0 (from changelog)

  • 1 minor enhancement:

    • Optionally allow autorun exit hook to remain active in forked child. (casperisfine)

5.19.0 (from changelog)

  • 2 minor enhancements:

    • Add metadata lazy accessor to Runnable / Result. (matteeyah)

    • Only load minitest/unit (aka ancient MiniTest compatibility layer) if ENV

  • 1 bug fix:

    • Minitest::TestTask enthusiastically added itself to default. (ParadoxV5)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 8 commits:

↗️ rack (indirect, 2.2.7 → 2.2.8) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 7 commits:

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by 5 commits:

🆕 base64 (added, 0.1.1)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
depfu[bot] commented 1 year ago

Closed in favor of #563.