sanghviharshit / script.kodi.lifx.ambilight

πŸ’‘πŸ“ΊπŸŒˆKodi add-on for Lifx lights with ambilight support.
https://bit.ly/kodilifx
GNU General Public License v2.0
32 stars 13 forks source link

catching WorkflowException when light fails to respond #19

Closed daviddever closed 6 years ago

daviddever commented 6 years ago

Added and tested exceptions to catch the WorkflowException thrown by lifxlan module when a light doesn't respond to set_color referenced in issue 6.

Thanks!

sanghviharshit commented 6 years ago

Thanks for the PR. Merged πŸ‘

sanghviharshit commented 6 years ago

I'm about to release a new version which is a complete rework of the addon and should resolve most of the existing issues. Do you mind testing it from the latest develop branch or the release/1.0.0 branch and let me know if you see any major issues?

Here is the PR if you are up for PR review as well - https://github.com/sanghviharshit/script.kodi.lifx.ambilight/pull/20

daviddever commented 6 years ago

Sure! I should have some time tomorrow morning to install and do some testing.

Thanks for all the work you put into maintaining this. πŸ‘