search

sanghviharshit / script.kodi.lifx.ambilight

💡📺🌈Kodi add-on for Lifx lights with ambilight support.
https://bit.ly/kodilifx
GNU General Public License v2.0
33 stars 13 forks source link

Disabling the script causes Kodi to crash #30

Open fl380 opened 6 years ago

fl380 commented 6 years ago

Disable the script

Kodi crashes

Kodi shouldn't crash

fl380 commented 6 years ago

Hello, could this be looked at please?

I hope that development of this script hasn't stopped. :worried:

sanghviharshit commented 6 years ago

Hey, can you please upload the logs again, it's not available anymore

fl380 commented 6 years ago

Hi, here's a new one from today:

https://pastebin.com/cr8sRKtS

sanghviharshit commented 6 years ago

Looking at the logs, I think what's happening is you are trying to disable the script while it's still initializing, leading to 14:30:39.217 T:5676 ERROR: CPythonInvoker(1, C:\Users\Admin\AppData\Roaming\Kodi\addons\script.kodi.lifx.ambilight\service.py): script didn't stop in 5 seconds - let's kill it Unfortunately, the way Lifx device discovery works, it takes longer than usual for the script to respond to disable request and causes Kodi to terminate it.

Do you know if this still happens when the addon is fully initialized and then trying to disable it causes Kodi to crash?

fl380 commented 6 years ago

Do you know if this still happens when the addon is fully initialized and then trying to disable it causes Kodi to crash?

Yes, it does. Here's a new log where about 6 minutes elapsed between starting the script and then disabling it, the error message is the same. This has also happened where kodi has been running for several days.

https://pastebin.com/i68FVu2M

sanghviharshit commented 6 years ago

I don't see any obvious issues in the logs. But I will look into improvements soon, but can't really promise anything :(