search

sangoma / react-native-callkeep

iOS CallKit framework and Android ConnectionService for React Native
ISC License
0 stars 0 forks source link

Pressing mute on native UI on samsung s8 quits app #9

Closed danjenkins closed 5 years ago

danjenkins commented 5 years ago

Log contains

06-28 10:28:31.726 11640 11640 E AndroidRuntime: FATAL EXCEPTION: main
06-28 10:28:31.726 11640 11640 E AndroidRuntime: Process: com.companyname.appname, PID: 11640
06-28 10:28:31.726 11640 11640 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object java.util.HashMap.get(java.lang.Object)' on a null object reference
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at io.wazo.callkeep.RNCallKeepModule$VoiceBroadcastReceiver.onReceive(RNCallKeepModule.java:490)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at android.support.v4.content.LocalBroadcastManager.executePendingBroadcasts(LocalBroadcastManager.java:313)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at android.support.v4.content.LocalBroadcastManager$1.handleMessage(LocalBroadcastManager.java:121)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at android.os.Handler.dispatchMessage(Handler.java:106)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at android.os.Looper.loop(Looper.java:214)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at android.app.ActivityThread.main(ActivityThread.java:7045)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at java.lang.reflect.Method.invoke(Native Method)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
06-28 10:28:31.726 11640 11640 E AndroidRuntime:    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

whereas the app doesn't crash on my pixel 2 xl

looks like it's line

args.putString("callUUID", attributeMap.get(EXTRA_CALL_UUID));

thats the culprit

bhuangy commented 5 years ago

Hey Dan, trying it with an S8 and not seeing the error. Can you try again after we've worked through the other issues?

danjenkins commented 5 years ago

Sure! No problem at all

On Fri, 28 Jun 2019, 18:53 bhuangy, notifications@github.com wrote:

Hey Dan, trying it with an S8 and not seeing the error. Can you try again after we've worked through the other issues?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sangoma/react-native-callkeep/issues/9?email_source=notifications&email_token=AAB3LLLFQZO7T5ORT5I54RLP4ZFZJA5CNFSM4H4DXLHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2YD2I#issuecomment-506823145, or mute the thread https://github.com/notifications/unsubscribe-auth/AAB3LLOHPIFLLK33BVEIBDDP4ZFZJANCNFSM4H4DXLHA .

kylekurz commented 5 years ago

@danjenkins have you had a chance to poke this again and see if it's still a problem?