Switchy IVR Outbound Dialer

sangoma / switchy

async FreeSWITCH cluster control

https://switchy.readthedocs.io/en/latest/

Mozilla Public License 2.0

69 stars 18 forks source link

Switchy IVR Outbound Dialer #17

Closed ncorbic closed 8 years ago

ncorbic commented 8 years ago

Standalone IVR outbound dialer application based on Switchy

goodboy commented 8 years ago

This can be rebased onto the branch from https://github.com/sangoma/switchy/pull/18 now. Please test and let me know if any further fixes are required. Thanks!

ncorbic commented 8 years ago

Cool

Nenad Corbic Sent from iPhone

On Dec 10, 2015, at 3:21 AM, goodboy notifications@github.com wrote:

This can be rebased onto the branch from #18 now. Please test and let me know if any further fixes are required. Thanks!

— Reply to this email directly or view it on GitHub.

goodboy commented 8 years ago

Run the flake8 linter over this and submit changes and then I'll review again.

ncorbic commented 8 years ago

Tyler. I have updated my code based on above suggestions. I have tested it again and it works :) So if you have no other comments plz merge.

Nenad

ncorbic commented 8 years ago

Tyler.

I committed changes you suggested. I think it's as good as it's going to get.
We can continue to perfect it later. Can we please merge.

Nenad

goodboy commented 8 years ago

@ncorbic next time you should comment on the actual lines of code you are referencing. It's difficult for me to know what you're talking about from general comments.

See here: https://help.github.com/articles/commenting-on-the-diff-of-a-pull-request/

I'll go through what I think is the list of quiffs:

"cancel_dtmf_timer()" -> agreed/done
sound directory location -> This was an issue of duplication. If the user wishes to specify a different directory for source playback files there is no restriction enforced here. Avoiding the duplication of a common directory path throughout the code does in no way restrict the user from using another directory. If fact we can allow them to pass this path in at app load time.
ivr route lookup map -> Again, this was not an effort to optimize but to factor. We should not be encouraging massive if blocks since it's not scalable. @vodik's suggestion I really think is the best plan of action.

goodboy commented 8 years ago

Added the flask.route like decorator support. Please review again guys @ncorbic @vodik.

Also @ncorbic this has not been tested at all. Can you do it or would you like me too?

ncorbic commented 8 years ago

I'll test.

Nenad Corbic Sent from iPhone

On Dec 15, 2015, at 3:02 AM, goodboy notifications@github.com wrote:

Added the flask.route like decorator support. Please review again guys @ncorbic @vodik.

Also @ncorbic this has not been tested at all. Can you do it or would you like me too?

— Reply to this email directly or view it on GitHub.

goodboy commented 8 years ago

Squashed down the history and fixed up the commit messages. @ncorbic @moises-silva @vodik please comment as this is ready to merge. Thanks!

ncorbic commented 8 years ago

I am good with it. I just re-tested it and it works.

Nenad