Sessions and Calls should be destroyed in CHANNEL_DESTROY?

sangoma / switchy

async FreeSWITCH cluster control

https://switchy.readthedocs.io/en/latest/

Mozilla Public License 2.0

69 stars 18 forks source link

Sessions and Calls should be destroyed in CHANNEL_DESTROY? #35

Open goodboy opened 8 years ago

goodboy commented 8 years ago

Not sure why (other then perf?) we aren't just destroying all Session and Call models in a _CHANNELDESTROY event handler? It seems to always come after _CHANNELHANGUP. This should also simplify the logic int he CDR app here such that we won't need to make temp bindings to sessions on the call instance.

goodboy commented 8 years ago

Just plugged in a callback and ran the unit tests. Seems to be fine? It'd be interesting to see the effects once we have proper benchmarking tests in place.