search

sangwonl / python-mpegdash

MPEG-DASH MPD(Media Presentation Description) Parser
MIT License
104 stars 53 forks source link

Added missing support for endNumber inside MultipleSegmentBase #57

Closed wreszelewski closed 2 years ago

wreszelewski commented 2 years ago

Hi! Thanks for this lib! I needed to use endNumber property of MultipleSegmentBase, which was missing, so I added it. Could you merge this into main repo and release new version to PyPi?

sangwonl commented 2 years ago

Thanks @wreszelewski for your support.

By the way, I don't see the field endNumber from DASH-MPD standard schema file. So, I'm not sure if we can include this field. Can someone comment on it?

cc: @davemevans

davemevans commented 2 years ago

Seems that schema file available at that link has not been updated to match the current (4th) edition of the DASH spec - it only seems to match the 2nd edition.

4th Edition schema is available at https://standards.iso.org/iso-iec/23009/-1/ed-4/en/DASHSchema-4th-Ed.zip (link is in the spec) and includes endNumber.

sangwonl commented 2 years ago

Seems that schema file available at that link has not been updated to match the current (4th) edition of the DASH spec - it only seems to match the 2nd edition.

4th Edition schema is available at https://standards.iso.org/iso-iec/23009/-1/ed-4/en/DASHSchema-4th-Ed.zip (link is in the spec) and includes endNumber.

Thanks, now I understood. We need to update our schema file.