search

sanic-org / sanic

Accelerate your web app development | Build fast. Run fast.
https://sanic.dev
MIT License
18.02k stars 1.55k forks source link

fix DeprecationWarning: Attribute s is deprecated and will be removed… #2926

Closed hamedsh closed 3 months ago

hamedsh commented 6 months ago

… in Python 3.14; use value instead

The attribute check within the 'ode.py' script has been updated. Previously, it checked whether the event has an attribute 's', however, this has been modified to check for the 'value' attribute instead. This ensures the correct attribute is being checked for the ongoing processes.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.014%. Comparing base (b6a8f8e) to head (457fa57). Report is 2 commits behind head on main.

:exclamation: Current head 457fa57 differs from pull request most recent head d2f7541. Consider uploading reports for the commit d2f7541 to get more accurate results

Files Patch % Lines
sanic/touchup/schemes/ode.py 50.000% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2926 +/- ## ============================================= - Coverage 88.134% 88.014% -0.120% ============================================= Files 94 94 Lines 7408 7409 +1 Branches 1307 1307 ============================================= - Hits 6529 6521 -8 - Misses 592 598 +6 - Partials 287 290 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahopkins commented 3 months ago

Thanks for the contribution. I went a slightly different route: #2959