search

sanitizers / chronographer-github-app

Your severe chronographer robot who is watching you record all the news to change note files!
https://github.com/apps/chronographer
GNU General Public License v3.0
11 stars 3 forks source link

[RFC] Allow intention management with labels #12

Open webknjaz opened 5 years ago

webknjaz commented 5 years ago

Idea

Project maintainers should be able to set labels instructing the bot to omit or enforce requiring change fragments.

Implementation

If bot:chronographer:skip label is set, the bot should report a neutral status. Otherwise, the bot should set bot:chronographer:required label if the fragment is missing and bot:chronographer:provided if it's there. The bot should allow maintainers to set bot:chronographer:more if the fragment is present but needs to be updated/extended or maybe if the PR needs several fragments. The bot should report "action_required". Once the requirement is fulfilled, the bot must remove this label.

Ref: https://github.com/tox-dev/tox/pull/1364#issuecomment-508544234

Fund with Polar

webknjaz commented 5 years ago

@asottile @gaborbernat @asvetlov does above look reasonable?

gaborbernat commented 5 years ago

Sounds good to me 👍

asvetlov commented 5 years ago
  1. bot:chronographer:required is 25-chars line. Does it fit into GitHub UI well?
  2. I don't understand the purpose of bot:chronographer:more. If the CHANGELOG record is incorrect -- reviewer points on it in review message, that's it. How does bot determine that the label should be removed?
  3. What is the purpose of adding bot:chronographer:provided label? To use it in PR filers?
webknjaz commented 5 years ago

Does it fit into GitHub UI well?

LGTM: gh-bot-req-label

How does bot determine that the label should be removed?

I think on the change to that file or adding a new one.

To use it in PR filers?

Yep, more or less.