False negative check

[asvetlov]

PR https://github.com/aio-libs/aiohttp/pull/3955 is marked red: ("Timeline protection: History fragments missing") but it has correct CHANGES/3551.misc.

@webknjaz please check what is going wrong?

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[webknjaz]

It's explained in the details section of https://github.com/aio-libs/aiohttp/runs/183618685:

No files matching re.compile('CHANGES/(?P[^./]+).(?Pbugfix|doc|feature|removal|trivial|vendor)(.\d+)?(.[^./]+)*$') pattern added

Since https://github.com/aio-libs/aiohttp/blob/master/pyproject.toml doesn't list the fragment types, the bot falls back to a hard-coded list defined here: https://github.com/sanitizers/chronographer-github-app/blob/0a112ca/chronographer/event_handlers.py#L258-L265

[webknjaz]

When the config has clearly defined types, the bot uses those for checking fragments. Here's a few examples:

• https://github.com/tox-dev/tox/blob/94436c3/pyproject.toml#L21-L49
• https://github.com/pypa/pip/blob/82dbcda/pyproject.toml#L13-L46

[webknjaz]

Maybe I could use https://github.com/hawkowl/towncrier/blob/ecd438c/src/towncrier/_settings.py#L13-L21 to identify defaults in a more stable way.