sanitizers / chronographer-github-app

Your severe chronographer robot who is watching you record all the news to change note files!
https://github.com/apps/chronographer
GNU General Public License v3.0
10 stars 3 forks source link

Rename the check to "Chronographer" #18

Closed pradyunsg closed 1 year ago

pradyunsg commented 4 years ago

Currently:

Screenshot 2020-01-01 at 4 30 55 PM

Suggestion:

webknjaz commented 4 years ago

Drop "Timeline protection: " prefix from the description.

This one is pretty straightforward. Feel free to send a PR. I think there's only 3 tiny changes to be made here: https://github.com/sanitizers/chronographer-github-app/blob/5119914/chronographer/event_handlers.py#L137 / https://github.com/sanitizers/chronographer-github-app/blob/5119914/chronographer/event_handlers.py#L237 / https://github.com/sanitizers/chronographer-github-app/blob/5119914/chronographer/event_handlers.py#L250

Rename the check to "Chronographer"

I was thinking along the lines of eventually adding a check that would show the compiled notes. So I'm not so sure about this. I was also thinking that it may be useful to make this changeable via a config.

Also, it probably makes sense to reinvent the terminology because it confuses folks. Maybe we could collect some further ideas before doing any changes here?

webknjaz commented 1 year ago

@pradyunsg I think, this is addressed with https://github.com/sanitizers/chronographer-github-app/commit/afa408d44d83726030cb699ec0c0c48169cd155e and https://github.com/sanitizers/chronographer-github-app/commit/d36ea77d8ed0f622e4e149ff9097fbff999ee1a6.

WDYT? Close if you agree.

pradyunsg commented 1 year ago

Works for me!