Seems like period/dot in filename breaks the GH action

sanitizers / chronographer-github-app

Your severe chronographer robot who is watching you record all the news to change note files!

https://github.com/apps/chronographer

GNU General Public License v3.0

11 stars 3 forks source link

Seems like period/dot in filename breaks the GH action #44

Open praiskup opened 2 months ago

praiskup commented 2 months ago

The leap-15.4.config has not been detected: https://github.com/rpm-software-management/mock/pull/1464

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

webknjaz commented 2 months ago

Technically, that's expected due to the semantics of how Towncrier itself perceives the fragments. You probably need to fix your usage of Towncrier. Either replace the period with an underscore or a dash, or perhaps even go for an orphan fragment (starting with a leading + which is special-cased in Towncrier). Usually, the first part is the issue/PR number to be linked. Why didn't you want to follow that format?

praiskup commented 2 months ago

I opened this, because we hit a real-life issue with towncrier:

$ towncrier create foo.bar.baz.config
Created news fragment at /home/praiskup/rh/projects/mock/mock/releng/release-notes-next/foo.bar.baz.config

At least we were allowed to create such file, I assumed that it "is a correct snippet" then, and I'd expect that the action accepts it as well. But is this a bug of towncrier create?