[TODO] Don't pre-authenticate installation removed event - Githubissues

sanitizers / octomachinery

🤖 Invisible engine driving octobot machines. Simple, yet powerful. [DEMO BOT @ https://github.com/sanitizers/chronographer-github-app] | [tutorial @ https://tutorial.octomachinery.dev] | [docs @ https://docs.octomachinery.dev] | official web-site is at -->

https://octomachinery.dev

GNU General Public License v3.0

56 stars 12 forks source link

[TODO] Don't pre-authenticate installation removed event #34

Open webknjaz opened 4 years ago

webknjaz commented 4 years ago

Fund with Polar

webknjaz commented 1 year ago

Implementation instruction: https://github.com/sanitizers/octomachinery/issues/49#issuecomment-1269075371.

webknjaz commented 1 year ago

In the past, we've had to do something similar for events that lack the 'installation' key:

webknjaz commented 1 year ago

Implementation instruction: #49 (comment).

Action items:

Here https://github.com/sanitizers/octomachinery/blob/3ce9e19/octomachinery/github/api/app_client.py#L110 add something like or (event.name == 'installation' and event.payload['action'] == 'deleted')
Figure out if installation.suspend should (always) be treated the same: https://docs.github.com/developers/webhooks-and-events/webhooks/webhook-events-and-payloads?actionType=suspend#installation
Test the above