sanitizers / patchback-github-app

https://github.com/apps/patchback
GNU General Public License v3.0
12 stars 4 forks source link

[FR] Add a label to PRs when a backport fails #39

Open gotmax23 opened 1 year ago

gotmax23 commented 1 year ago

It would be nice if patchback allowed adding a label to PRs when a backport fails. The label name should be configurable.

Upvote & Fund

Fund with Polar

gotmax23 commented 1 year ago

I guess this relates to https://github.com/sanitizers/patchback-github-app/issues/12. Perhaps @felixfontein's idea to add a different label when a backport suceeds is a better one.

felixfontein commented 1 year ago

Sometimes backporting fails without the backporting bot code completing (bug, or process is killed). In that case adding a label won't work.

webknjaz commented 1 year ago

Thanks for the suggestion! Some kind of a design vision / UX / config structure would be welcome. As for the crashes, I'd mention the case of GitHub's own eventual consistency and outages. Still, we could probably do an optimistic "best effort", like other apps.

webknjaz commented 1 year ago

Note that when you talk about a failing backport and just one label, it might be confusing as people often request backporting to many branches. The newest ones succeed while the older ones might be more suseptible to conflicts. It might end up being a confusing thing.

Also note that the bot is stateless.

gotmax23 commented 1 year ago

Thanks for the suggestion! Some kind of a design vision / UX / config structure would be welcome.

Yeah, sure. I'll give it more thought.

gotmax23 commented 1 year ago

I proposed a solution in https://github.com/sanitizers/patchback-github-app/pull/40.