sanity-io / example-company-website-gatsby-sanity-combo

This is an example company website using Gatsby and Sanity in combination.
https://example-company-website-gatsby-sanity-combo.now.sh
MIT License
274 stars 142 forks source link

sanity-deploy from a fresh install fails to deploy/build properly #103

Closed david-j-davis closed 5 years ago

david-j-davis commented 5 years ago

Describe the bug From a fresh clone of the project, and creating a new project, and deployment (sanity-deploy), the project fails to build properly, and the "Connection to Sanity.io" loading animation doesn't go away. In addition, Chrome dev tools reports a failed build. See screenshots.

To Reproduce Steps to reproduce the behavior:

  1. Clone the project
  2. Change the project ID for a fresh deployment
  3. yarn run sanity-deploy
  4. See error

Expected behavior Deployment shouldn't fail

Screenshots loading-never-stops Screen Shot 2019-06-07 at 9 54 22 PM

Desktop (please complete the following information): OS: OSX 10.14.5 Browser: Chrome Version 74.0.3729 @sanity/cli 0.140.33 (up to date) @sanity/base 0.140.33 (up to date) @sanity/cli 0.140.33 (up to date) @sanity/components 0.140.33 (up to date) @sanity/core 0.140.32 (up to date) @sanity/default-layout 0.140.33 (up to date) @sanity/default-login 0.140.15 (up to date) @sanity/desk-tool 0.140.33 (up to date)

kmelve commented 5 years ago

I have trouble reproducing this as well.

Do you see any error if you try to run the studio locally? So either by running yarn start in the root folder, or sanity start in the /studio folder?

david-j-davis commented 5 years ago

Hi Knut, I have no trouble running this locally- it compiles/builds just fine and can view the studio no problem. Only when I sanity deploy do I see the issue.

On Fri, Jun 7, 2019 at 10:04 PM Knut Melvær notifications@github.com wrote:

I have trouble reproducing this as well.

Do you see any error if you try to run the studio locally? So either by running yarn start in the root folder, or sanity start in the /studio folder?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sanity-io/example-company-website-gatsby-sanity-combo/issues/103?email_source=notifications&email_token=AA2WB3Y6EM4KBXDS4UOS73TPZM4VLA5CNFSM4HWDFTB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHNUUQ#issuecomment-500095570, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2WB34DTCWEI4QMKGUVSVLPZM4VLANCNFSM4HWDFTBQ .

kmelve commented 5 years ago

The Unexpected token < at the 1 position at least tells me that there's something weird going on with the javascript files. What do these files actually contain?

david-j-davis commented 5 years ago

Well, I've not modified any of the files that exist in the repo except for updating the projectID in sanity.json, and it's peculiar that I cannot deploy these same set of files without an error, and you can. https://github.com/sanity-io/example-company-website-gatsby-sanity-combo/tree/master/studio

On Fri, Jun 7, 2019 at 10:21 PM Knut Melvær notifications@github.com wrote:

The Unexpected token < and the 1 position at least tells me that there's something weird going on with the javascript files. What do these files actually contain?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sanity-io/example-company-website-gatsby-sanity-combo/issues/103?email_source=notifications&email_token=AA2WB37K4TY5BVLNP5VNOJDPZM6WRA5CNFSM4HWDFTB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHN7QY#issuecomment-500096963, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2WB34G3TOL32Y45RFLMADPZM6WRANCNFSM4HWDFTBQ .

kmelve commented 5 years ago

Fully agree! Even if it might be some sort of edge case, that doesn't help you much. If you do a sanity build from the studio folder, can you confirm that the files in studio/dist/static/js/app.bundle.js and studio/dist/static/js/vendor.bundle.js are indeed minified JavaScript?

david-j-davis commented 5 years ago

Hi Knut, confirmed, sanity build in the studio folder produces minified app and vendor bundles. On another note, I can at least confirm that a fresh sanity init with the Blog example I can successfully deploy without a build failure.

On Fri, Jun 7, 2019 at 10:37 PM Knut Melvær notifications@github.com wrote:

Fully agree! Even if it might be some sort of edge case, that doesn't help you much. If you do a sanity build from the studio folder, can you confirm that the files in studio/dist/static/js/app.bundle.js and studio/dist/static/js/vendor.bundle.js are indeed minified JavaScript?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sanity-io/example-company-website-gatsby-sanity-combo/issues/103?email_source=notifications&email_token=AA2WB3ZN4LSJMPA4EVTHH7DPZNATDA5CNFSM4HWDFTB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHOFHI#issuecomment-500097693, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2WB3ZGEZJGDI3PAPFWQLDPZNATDANCNFSM4HWDFTBQ .

kmelve commented 5 years ago

That's good to hear. I'm still curious what may have happened with your deployed studio, however. Feel free to send me an email with the studio URL and the team can take a closer look at it to figure out what may have happened.

For what it's worth: The portfolio starter on sanity.io/create is very similar to this one.

kmelve commented 5 years ago

We found the error. When preparing this starter to work with Zeit’s Now, I set the studio basepath to /studio. That doesn't work with our hosting. This is now fixed.