enabling a way to auth to npm registries for private packages

fostimus commented 1 year ago

I have a private package in my Sanity project - something I'm sure other people have or will have.

I'm not sure how to test this, if someone points me in the direction to test this Dockerfile/GitHub action locally, happy to verify. But this will enable Sanity Studios with private packages to be deployed within GitHub Actions, by specifying:

NPM_SCOPE: the scope of the private package, e.g. @sanity
NPM_TOKEN: the token that allows GitHub actions to download and use the private package
REGISTRY_DOMAIN: the domain of the private registry. Can be registry.npmjs.org, npm.pkg.github.com, or some other registry domain.

fostimus commented 1 year ago

@kmelve seems like you're the man in charge here - can you take a look at this PR?

ryami333 commented 1 year ago

@stipsan would you care to comment on the concerns that I raised in my review which were disregarded before merge?

stipsan commented 1 year ago

Hi @ryami333, it seemed like @fostimus's intention were to keep working on this based on your interaction. Merging this PR weren't meant to shut down your collaboration, it's just to break the work into multiple iterations as we feel this addition is valuable enough to be merged now rather than later 😄

sanity-io / github-action-sanity

enabling a way to auth to npm registries for private packages #14