search

sanity-io / sanity-mux-player

Play videos in the frontend uploaded with the MUX Sanity plugin
https://github.com/sanity-io/sanity-plugin-mux-input
21 stars 5 forks source link

[RFC] Passing "leftover" props to <video> #3

Closed tomsseisums closed 5 years ago

tomsseisums commented 5 years ago

It'd be great if it was possible to add event handlers the React way and any other unthought of or future <video> prop.

While I'm at it, it'd be also great if one could attach custom onClick handler by merging with the internal handleClick.

skogsmaskin commented 5 years ago

Yes, this is straight up a front end rendering module parted from our Sanity studio MUX-integration code :moon: It's still on 0.0.24, but the aim is to be flexible for front end rendering of video. Thanks for posting the first PR @joltmode ! :)