search

sanity-io / sanity-mux-player

Play videos in the frontend uploaded with the MUX Sanity plugin
https://github.com/sanity-io/sanity-plugin-mux-input
21 stars 5 forks source link

Video muted set to false, still plays mute #9

Closed david-j-davis closed 4 years ago

david-j-davis commented 4 years ago

Hello, I have a mux component set here: https://github.com/Marmt-Group/client-rock-solid/blob/master/web/src/components/video-player/index.js and a live example of the issue here. Click on the play button, and observe that muted set to false is still playing mute. https://gifted-dijkstra-333b71.netlify.com/ Screen Shot 2019-12-20 at 5 14 20 PM

david-j-davis commented 4 years ago

So it appears the player does not allow autoplay=true and muted=false, only autoplay=true and muted=false. Why is that, and I wish that wasn't the case...

skogsmaskin commented 4 years ago

Hi @david-j-davis. This is a measure for better supporting autoplay. Browsers will not allow autoplay if the sound is not muted (in general - there are some exceptions).

Read more about how e.g. Chrome deals with this (other browsers also measures for this): https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

Also: https://developer.mozilla.org/en-US/docs/Web/Media/Autoplay_guide

I guess we could allow to set both autoplay=true and muted=false, but that would only work in special cases where the user already has deliberately played videos with sound on your site.

david-j-davis commented 4 years ago

Thanks for the reply. I guess if this is a matter of best practices then I'm ok with it as it is and will let my client know.

On Thu, Jan 2, 2020 at 1:54 AM Per-Kristian Nordnes < notifications@github.com> wrote:

Hi @david-j-davis https://github.com/david-j-davis. This is a measure for better supporting autoplay. Browsers will not allow autoplay if the sound is not muted (generally - there are some exceptions).

Read more about how Chrome deals with this here: https://developers.google.com/web/updates/2017/09/autoplay-policy-changes

I guess we could allow to set both autoplay=true and muted=false, but that would only work in special cases where the user already has deliberately played videos with sound on your site.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sanity-io/sanity-mux-player/issues/9?email_source=notifications&email_token=AA2WB34AQV2VJSUPI6E27UDQ3W2WDA5CNFSM4J6EW2JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH57OOA#issuecomment-570160952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2WB322PJHZML3572OEC33Q3W2WDANCNFSM4J6EW2JA .