search

sanity-io / sanity-plugin-asset-source-cloudinary

Access and select photos from your Cloudinary account within the Sanity Studio.
MIT License
10 stars 4 forks source link

[Feature] Support for cloudinary and video selection #4

Open matthewharwood opened 4 years ago

matthewharwood commented 4 years ago

Uploading image and selecting them from sanity is an excellent workflow for authors. Cloudinary supports uploading video too! Unfortunately selecting videos with asset-source-cloudinary will error out

 if (imageAssets.length === 0) {
                throw new Error('The selection did not contain any images.');
            }

Could we get the ability to select video or image with asset-source-cloudinary plugin and and have sanity store the path from cloudinary (including the folder) https://github.com/sanity-io/sanity-plugin-asset-source-cloudinary/issues/3?

Note: I don't want to over complicate this feature... Sselection can be rough e.g. no previews or some placeholder icon... Data type can stay Image too... Maybe down the line we update the data type to "Media" and previews are more like the mux plugin... that said, I just want to be able to select and store the path of a video from cloudinary

Note I know that we have the mux plugin too but mux is just too expensive and I'd rather not host two cdns.

skogsmaskin commented 3 years ago

I agree, that would be nice!

For supporting video we would need to build a separate plugin, as the implementation of part:@sanity/form-builder/input/image/asset-source as this one does, ties directly into Sanity's image types and image pipeline in a generic way that is officially supported by the studio (that's why you get a Select from button on the default image type component when you install it, without having to do anything special).

It should be possible to make support for videos in Cloudinary though by just using it's own types and custom field component for that type (like the MUX plugin does). But that's a different plugin than this one.