No feedback when api requests fail - Githubissues

sanity-io / sanity-plugin-asset-source-unsplash

Search photos on Unsplash and use them directly inside of your Sanity Studio.

MIT License

17 stars 5 forks source link

No feedback when api requests fail #2

Open edenstrom opened 5 years ago

edenstrom commented 5 years ago

Current behavior

When choosing an image, and the request fails for some reason, no feedback is given to the user.

Expected behavior

Some feedback that the request failed.

Reproduction

Install Privacy Badger
Open Select From -> Unsplash
In Privacy Badger, block images.unsplash.com
Choose image
Error is logged in console, but no feedback is given to user

Environment

Software	Version
@sanity/core	0.146.3
@sanity/desk-tool	0.146.3
sanity-plugin-asset-source-unsplash	0.1.1

PS. Really good work with the pluggable asset sources. Really cool 💯

kmelve commented 5 years ago

This makes sense. Thanks for reporting!