sanity-io / sanity-plugin-iframe-pane

Display any URL in a View Pane, along with helpful buttons to copy the URL, display a mobile size, reload the iframe or open in a new tab
MIT License
47 stars 13 forks source link

doc is still null in 3.1.2 #91

Closed charlottedamm closed 1 year ago

charlottedamm commented 1 year ago

Describe the bug

The bug where the the document property for the url option is null when there's no draft version of a document, is still there after the 3.1.2. update

To Reproduce

See issues https://github.com/sanity-io/sanity-plugin-iframe-pane/issues/89 and https://github.com/sanity-io/sanity-plugin-iframe-pane/issues/88

Which versions of Sanity are you using?

@sanity/cli (global)          3.20.1 (up to date)
@sanity/assist                1.2.15 (up to date)
@sanity/color-input            3.1.0 (up to date)
@sanity/eslint-config-studio   3.0.1 (up to date)
@sanity/ui                     1.9.3 (up to date)
@sanity/vision                3.20.1 (up to date)
sanity                        3.20.1 (up to date)

Which versions of Node.js / npm are you running?

v20.9.0
10.1.0
rdunk commented 1 year ago

Closing in favour of reopening #89.

salex97 commented 1 year ago

@rdunk as #89 is locked ("This conversation has been locked as resolved and limited to collaborators."), I'll answer your question here:

Are you able to confirm if 3.1.2 fixes the issue for you?

Yes, for me the issue is fixed by 3.1.2, everything works fine now. Thx for the quick fix!

rdunk commented 1 year ago

Pesky bot, sorry about that. Conversation is now unlocked.

Thanks for confirming @salex97.

rdunk commented 1 year ago

89 was closed by the author so unlocking the conversation here.

The issue has been reported as fixed by others, @charlottedamm would you be able to confirm that you are definitely experiencing this problem using 3.1.2? Can reopen this issue if so.

charlottedamm commented 1 year ago

@rdunk yes, still experiencing this issue with 3.1.2, both locally and in production

rdunk commented 1 year ago

Thanks for confirming, fix incoming in #92.

charlottedamm commented 1 year ago

So sorry, managed to confirm that it does work in 3.1.2! We had a separate issue with building that caused the cache to never be invalidated

rdunk commented 1 year ago

No problem, glad to hear it. Looks like #92 covers the last remaining edge case so will close this issue.