search

sanity-io / sanity-plugin-shopify-assets

MIT License
20 stars 1 forks source link

feat: strict schema support #2

Closed rexxars closed 1 year ago

rexxars commented 1 year ago

Currently, the schema definitions use inline objects for the asset metadata and asset preview fields. This is incompatible with "strict schemas", which prevents a GraphQL API from being deployed.

This PR moves those types to separate, named object types (shopify.assetMetadata and shopify.assetPreview).

I'm not super familiar with how data flows in these shopify scenarios - is data imported or created in-studio? If imported, we should check what the source puts into the meta._type and preview._type fields - they should (preferably) be shopify.assetMetadata and shopify.assetPreview, or alternatively not be present.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: