search

sanity-io / sanity-template-astro-clean

Clean starter template with Astro
https://template-astro-clean.sanity.build/
119 stars 39 forks source link

This template isn't working for persons with Astro 4 #37

Closed narration-sd closed 5 months ago

narration-sd commented 10 months ago

The template builds and operates as-is, but when persons upgrade it to use latest packages, including Astro 4 and @sanity/astro to accompany that, there are multiple failures.

To reproduce, run ncu -u from the top folder, and then attempt npm run dev, or npm run build.

Expected, is that with current packages, the template should just work.

I've created a fork with upgrades to fit the current software, available on branch main to make it easy to use. I'm not presenting a PR for these yet, because they necessarily use a temporarily published upgrade of @sanity/astro, on @narration-sd/santy-astro.

When its PR for official @sanity/astro resolves, I'll update the fork, and PR this repo for a completed result, reporting again here also.

vmitsaras commented 9 months ago

https://github.com/narration-sd/sanity-template-astro-clean Is there any progress being made towards a merge?

narration-sd commented 9 months ago

Hi Vaslis @vmitsaras, in fact I've just last night released the PR here: #40.

You can work from the upgraded version for now which others have, as I think it's pretty solid.

This offers a much nicer experience I think, beside including Astro 4, along with all dependencies at latest code date up to now.

As you can read, the final PR needs another PR to be approved so its results can be included, and hopefully this one will follow that very shortly in the progress priority at Sanity.

christianhg commented 5 months ago

Hi! Sorry about that! I've now made sure to upgrade the dependencies used by this template.