search

sanity-io / sanity-template-astro-clean

Clean starter template with Astro
https://template-astro-clean.sanity.build/
119 stars 40 forks source link

Add support for Visual Editing. #46

Open daveli opened 5 months ago

daveli commented 5 months ago

👋 This PR upgrades the template to Astro 4 and Sanity 3.46 with support for visual editing.

vercel[bot] commented 5 months ago

@daveli is attempting to deploy a commit to the Sanity Team on Vercel.

A member of the Team first needs to authorize it.

socket-security[bot] commented 5 months ago

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
template-astro-clean ❌ Failed (Inspect) Jun 28, 2024 7:36am
christianhg commented 5 months ago

Hi @daveli ! Thanks a lot for this!

The PR was a bit much to take in (too many unrelated changes at once) so I decided to upgrade the relevant dependencies in https://github.com/sanity-io/sanity-template-astro-clean/pull/34

I took the liberty to rebase your branch to resolve the resulting merge conflicts caused by merging #34 – I hope that's alright with you.

Now, your PR is more focused on adding Visual Editing support to the template, which is great! Could you help me out and remove the rest of the unrelated changes? For dependencies, we probably just need to add @sanity/visual-editing by now and not pin or downgrade other dependencies. Also, I'm unsure the change to the node version strictly relevant to this PR.

Thanks!

daveli commented 5 months ago

👋 I have updated the PR to only include the changes to support Visual Editing. I will create a different PR to address the loading of environment variables once this one is merged 😎