sanity-io / sanity-template-gatsby-portfolio

A Gatsby portfolio site powered by Sanity for https://www.sanity.io/create
https://www.sanity.io/create/?template=sanity-io%2Fsanity-template-gatsby-portfolio
69 stars 18 forks source link

Update schema naming to avoid confusion #30

Closed vicmeow closed 4 years ago

vicmeow commented 5 years ago

I've updated the schema name of project to sampleProject to make it clearer that it's a generic schema name and can be changed depending on your own needs and to avoid confusion.

I've tested it and I think I managed to change it in all the right places, but if someone more familiar with this template could double check, I think that would be great.

bjoerge commented 5 years ago

There seems to be an schema error here: image

https://deploy-preview-30--sanity-template-gatsby-portfolio-studio.netlify.com/dashboard

This also means we need to update the exported sample dataset, I presume?

vicmeow commented 5 years ago

There seems to be an schema error here: image

https://deploy-preview-30--sanity-template-gatsby-portfolio-studio.netlify.com/dashboard

This also means we need to update the exported sample dataset, I presume?

Oops true! Thanks! Fixed.

netlify[bot] commented 5 years ago

Deploy preview for sanity-template-gatsby-portfolio-studio ready!

Built with commit 709501a59229e608582aaf184c825093f7d8cef9

https://deploy-preview-30--sanity-template-gatsby-portfolio-studio.netlify.com

evenwestvang commented 5 years ago

I'm all 👍 about the naming change. 🏹

vicmeow commented 4 years ago

How can I restart the build for this to see if it's working?

kmelve commented 4 years ago

I think you'll have to push a fix for it?

evenwestvang commented 4 years ago

@jemmima I think this was started, but never completed?

vicmeow commented 4 years ago

I’ve tried to confirm that this is working, but I need help or some else to try it. I’ve followed the instructions that both Bjørge snd Knut gave me, but couldn’t get it to work. The problem: when you open the studio, there are no sampleProject types in the lists. Solution: update the existing data and point the studio to updated dataset to test (I think).

kmelve commented 4 years ago

Everything with the studio and data was as it should be, but there were some GraphQL queries in the frontend that had escaped the renaming and hence broke the build. Pushed a fix for it now!

vicmeow commented 4 years ago

Thanks Knut! 🙏

evenwestvang commented 4 years ago

Great! Thank you to both of you for clarifying and 🚢ing!