sanity-io / sanity

Sanity Studio – Rapidly configure content workspaces powered by structured content
https://www.sanity.io
MIT License
5.08k stars 411 forks source link

Dialogs/Modals are not scrollable when they overflow #4573

Open eliasm307 opened 1 year ago

eliasm307 commented 1 year ago

Describe the bug

Some users have their browsers zoomed in for accessibility or have smaller screens which means dialogs in the studio overflow, but they dont show any scrollbars so some content cant be accessed.

To Reproduce

Steps to reproduce the behavior:

  1. Open a dialog
  2. Zoom in

Expected behavior

If the dialog content overflows then scrollbars should be shown, e.g. msedge_0puxsvV3ek

Screenshots

msedge_9ujhOfcXhv

Which versions of Sanity are you using?

@sanity/cli (global) 3.12.0 (up to date) @sanity/cli 3.12.0 (up to date) @sanity/vision 3.12.0 (up to date) sanity 3.12.0 (up to date)

What operating system are you using?

Windows

Which versions of Node.js / npm are you running?

Run npm -v && node -v in the terminal and copy-paste the result here. 8.19.2 v18.12.1

eliasm307 commented 1 year ago

FYI I applied the fix in the example using this CSS

[data-ui="DialogCard"] {
  & > [data-ui="Card"] {
    overflow: auto;
  }
}