search

sanity-io / visual-editing

https://visual-editing-studio.sanity.build
MIT License
36 stars 20 forks source link

Expose createChannelsNode and ChannelsNode type #1755

Open osnoser1 opened 1 month ago

osnoser1 commented 1 month ago

Is your feature request related to a problem? Please describe. Hi all! :smile: I'm working on a visual editing + preview-kit implementation for live real-time for Angular. It is almost done, but I have a concern; I'm using an internal package of the visual-editing repo, the createChannelsNode function of the @repo/channels , so I copied the content. Still, this is not a good approach.

Describe the solution you'd like Expose createChannelsNode function and the ChannelsNode type or publish to npm the channels package. The idea is to open the visual editing implementation outside of the react ecosystem.

rdunk commented 1 month ago

Hello! We are currently re-working the channels package to move away from having just an internal repo (i.e. we will likely publish on npm) so I would avoid replicating that logic directly for now if you can.

osnoser1 commented 1 month ago

Hello! We are currently re-working the channels package to move away from having just an internal repo (i.e. we will likely publish on npm) so I would avoid replicating that logic directly for now if you can.

Hi, I'm glad to know this 😄

Well, right now I am testing the angular implementation of visual-editing, I was thinking of releasing a new version with this new feature in the library, and then I can wait for your changes and make the internal refactor, in theory, this shouldn't be a breaking change.

I'll double-check here before making the release