Drag and Drop Minimap v1

georgedoescode commented 1 week ago

This PR:

Implements minimap scaling
Implements a small prompt to show when minimaps are available
Tidies up existing drag and drop code, creating a new geometry utils file that we can use for other areas
Updates drag sequence logic so that minimaps can persist until the shift key is unpressed
Simplifies inverse transform logic using native browser APIs
Updates renderVisualEditing to place our div outside of <body> - this greatly simplifies handling scaling overlays while minimaps are enabled.

I went back and forth on emitting events for the minimap scaling and applying the transforms, etc in Overlays. It feels simpler to keep it in the handler for now, but I'm open to feedback!

Next Steps:

In the interest of moving forward, and being able to demo this tomorrow, I have split a few small tasks out:

Enable developers to opt-out of minimaps
Hide overlays during minimap scaling animation sequences (listeners already attached)
Allow developers to define a custom scale target for minimaps (?)
Disable click events on overlays while minimaps are open

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
live-visual-editing-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-astro	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-next	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-next-with-i18n	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-nuxt	❌ Failed (Inspect)			Sep 24, 2024 0:35am
visual-editing-page-builder-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-remix	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am
visual-editing-svelte	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 24, 2024 0:35am

1 Skipped Deployment

socket-security[bot] commented 1 week ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/next-sanity@9.5.1-canary.18	Transitive: environment, eval, filesystem, network, shell, unsafe	`+1257`	239 MB	armandocerna, ash, atombender, ...56 more

🚮 Removed packages: npm/next-sanity@9.5.1-canary.15

View full report↗︎

sanity-io / visual-editing

Drag and Drop Minimap v1 #1857