search

sanity-tool / sanity

1 stars 0 forks source link

Move reusable code to api module #16

Closed okutane closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #16 into master will increase coverage by 0.59%. The diff coverage is 89.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     85.73%   86.32%   +0.59%     
- Complexity      343      412      +69     
============================================
  Files            59       71      +12     
  Lines          1402     1426      +24     
  Branches        168      156      -12     
============================================
+ Hits           1202     1231      +29     
+ Misses          159      152       -7     
- Partials         41       43       +2
Flag Coverage Δ Complexity Δ
#C 82.32% <87.98%> (+1.3%) 391 <104> (+68) :arrow_up:
#Cpp 71.87% <80.76%> (+1.33%) 333 <93> (+57) :arrow_up:
#IR 16.52% <31.8%> (ø) 47 <17> (+6) :arrow_up:
#ObjectiveC 62.2% <76.92%> (+1.14%) 281 <96> (+58) :arrow_up:
#Rust 58.86% <70.12%> (+1.59%) 274 <85> (+56) :arrow_up:
Impacted Files Coverage Δ Complexity Δ
...main/java/ru/urururu/sanity/api/cfg/Primitive.java 57.14% <ø> (ø) 2 <0> (ø) :arrow_down:
...c/main/java/ru/urururu/sanity/api/BlockParser.java 100% <100%> (ø) 4 <4> (?)
.../java/ru/urururu/sanity/cpp/NativeValueParser.java 92.85% <100%> (ø) 12 <1> (?)
...ain/java/ru/urururu/sanity/api/cfg/CfgBuilder.java 100% <100%> (ø) 4 <4> (?)
...u/urururu/sanity/api/cfg/NativeCfgBuildingCtx.java 100% <100%> (ø) 9 <4> (?)
...main/java/ru/urururu/sanity/api/ParsersFacade.java 100% <100%> (ø) 8 <8> (?)
...ava/ru/urururu/sanity/cpp/NativeParsersFacade.java 100% <100%> (ø) 1 <1> (?)
...va/ru/urururu/sanity/cpp/NativeBytecodeParser.java 88.88% <100%> (-1.02%) 17 <8> (-5)
...c/main/java/ru/urururu/sanity/cpp/ValueParser.java 100% <100%> (ø) 1 <1> (?)
...java/ru/urururu/sanity/api/SourceRangeFactory.java 100% <100%> (ø) 1 <1> (?)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4493f08...18f43d4. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #16 into master will increase coverage by 0.59%. The diff coverage is 89.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #16      +/-   ##
============================================
+ Coverage     85.73%   86.32%   +0.59%     
- Complexity      343      412      +69     
============================================
  Files            59       71      +12     
  Lines          1402     1426      +24     
  Branches        168      156      -12     
============================================
+ Hits           1202     1231      +29     
+ Misses          159      152       -7     
- Partials         41       43       +2
Flag Coverage Δ Complexity Δ
#C 82.32% <87.98%> (+1.3%) 391 <104> (+68) :arrow_up:
#Cpp 71.87% <80.76%> (+1.33%) 333 <93> (+57) :arrow_up:
#IR 16.52% <31.8%> (ø) 47 <17> (+6) :arrow_up:
#ObjectiveC 62.2% <76.92%> (+1.14%) 281 <96> (+58) :arrow_up:
#Rust 58.86% <70.12%> (+1.59%) 274 <85> (+56) :arrow_up:
Impacted Files Coverage Δ Complexity Δ
...main/java/ru/urururu/sanity/api/cfg/Primitive.java 57.14% <ø> (ø) 2 <0> (ø) :arrow_down:
...u/urururu/sanity/cpp/NativeSourceRangeFactory.java 88.88% <100%> (ø) 11 <2> (?)
...u/urururu/sanity/api/cfg/NativeCfgBuildingCtx.java 100% <100%> (ø) 9 <4> (?)
...c/main/java/ru/urururu/sanity/cpp/ValueParser.java 100% <100%> (ø) 1 <1> (?)
...ain/java/ru/urururu/sanity/api/cfg/CfgBuilder.java 100% <100%> (ø) 4 <4> (?)
.../java/ru/urururu/sanity/cpp/NativeValueParser.java 92.85% <100%> (ø) 12 <1> (?)
...main/java/ru/urururu/sanity/api/ParsersFacade.java 100% <100%> (ø) 8 <8> (?)
...c/main/java/ru/urururu/sanity/api/BlockParser.java 100% <100%> (ø) 4 <4> (?)
...java/ru/urururu/sanity/api/SourceRangeFactory.java 100% <100%> (ø) 1 <1> (?)
...va/ru/urururu/sanity/cpp/NativeBytecodeParser.java 88.88% <100%> (-1.02%) 17 <8> (-5)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4493f08...18f43d4. Read the comment docs.

okutane commented 7 years ago

SonarQube analysis reported 25 issues

Watch the comments in this conversation to review them.

2 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR NativeSourceRangeFactory.java#L42: This block of commented-out lines of code should be removed. rule
  2. MAJOR NativeSourceRangeFactory.java#L85: Invoke method(s) only conditionally. rule