sanjacob / BlackboardSync

Download your Blackboard Learn content automatically
https://bbsync.app
GNU General Public License v2.0
34 stars 11 forks source link

Add support for École supérieure privée d'ingénierie et de technologie #423

Closed sanjacob closed 1 month ago

sanjacob commented 1 month ago

Created on behalf of @TheLime1 Closes #422

github-actions[bot] commented 1 month ago

The build process has succeeded. Please test either package-macos-12 (x86_64), package-macos-14 (arm64), or package-windows-latest. You can find them here at the bottom of the page. Let me know if everything seems fine.

TheLime1 commented 1 month ago

i test it , the download process works fine

sanjacob commented 1 month ago

@TheLime1 Could you let me know the error you are seeing regarding the french characters?

TheLime1 commented 1 month ago

image

TheLime1 commented 1 month ago

I think it's an encoding issue, but the download process works

sanjacob commented 1 month ago

I have made #427 which should solve that, after I merge you can edit your issue so that this PR is re-created. You could make a simple edit such as adding one space to the "additional information" field. I will let you know when I have merged #427.

I think I can just rebase it, so no action needed on your part.

TheLime1 commented 1 month ago

i was gonna test it right now hahah , thank you :)

TheLime1 commented 1 month ago

image

Fixed

sanjacob commented 1 month ago

@TheLime1 Just one more thing before I merge this. All other universities have their name in Title Case, so it would be a good idea to follow this format. However, I'm not sure how this would look given that it's in French. From their website and social media it is similar to what you provided but some of them have "Technologies" in plural rather than singular. Moreover they have written "Ecole" without the accent (example). Just edit the university name to be in the correct format in Title Case and I'll merge it.

TheLime1 commented 1 month ago

i dont have direct editing rights here , so i made #428

sanjacob commented 1 month ago

You can edit the issue directly and the PR will also update. Furthermore, I'd rather have no abbreviations in the name. I don't need you to follow the name as it appears on their website. I just want you to provide a Title Case version of the one you had already given me, or the one you think most appropriate, but in Title Case.

TheLime1 commented 1 month ago

@sanjacob you can take a look

sanjacob commented 1 month ago

@TheLime1 So is the accent on the first letter optional? Just curious

TheLime1 commented 1 month ago

In French, it's rare to use accents on uppercase letters, but both are correct