search

sanjayV / ng-image-fullscreen-viewer

An Angular responsive image fullscreen viewer. Also support youtube and mp4 video urls.
MIT License
23 stars 24 forks source link

Force Refresh #8

Open myounees opened 3 years ago

myounees commented 3 years ago

Hi, nice implementation easy to use package. yet it needs some enhancements: 1) when using in a child component, it doesn't render (consider a child of app component and there you show the image-fullscreen-viewer). 2) when image is url, the spinner continue to spin even if the image is loaded, you need to close the fullscreen-viewer and reopen it again.

ukaya0 commented 3 years ago

I have the same issue when I use changeDetection: ChangeDetectionStrategy.OnPush

jjbenitez026 commented 3 years ago

Hi, nice implementation easy to use package. yet it needs some enhancements:

  1. when using in a child component, it doesn't render (consider a child of app component and there you show the image-fullscreen-viewer).
  2. when image is url, the spinner continue to spin even if the image is loaded, you need to close the fullscreen-viewer and reopen it again.

Any workaround to the point 2.?