search

sanjaya1996 / proShop-EcommerceWebApp

Ecommerce web application Project ( using MERN Stack)
7 stars 5 forks source link

I couldn't implement Google Sign In. #2

Open talmax1124 opened 3 years ago

talmax1124 commented 3 years ago

Can you create a PR to my repo. I have way too many errors with your code. I have followed the tutorial and couldn't do it.

Here is my repo: https://github.com/Obsession-Boutique

talmax1124 commented 3 years ago

Ok, I was going to do that, but I just want security to be secure.

talmax1124 commented 3 years ago

Ok, & I confirm everything is working perfectly now! Would you mind helping me with something else? @sanjaya1996

sanjaya1996 commented 3 years ago

I would love to. Keep in touch I will let you know when I will be free and we can work on that together.

On Sun, 9 May 2021 at 5:50 pm, Carlos @.***> wrote:

Ok, & I confirm everything is working perfectly now! Would you mind helping me with something else?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sanjaya1996/proShop-EcommerceWebApp/issues/2#issuecomment-835732162, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANXTXW3WZKW7LHZAHR53VM3TMY5FTANCNFSM43XWJUKA .

talmax1124 commented 3 years ago

Ok, thanks. It really means alot to me that someone is helping me and has been nice and helful. Thank you alot

talmax1124 commented 3 years ago

Hello @sanjaya1996 hope you are doing fine. Have you ever thought of a feature letting a user register normally then link it with google afterwards? So like if a person does registration without google and want to use the sign in with google, is there a way to make this possible?

sanjaya1996 commented 3 years ago

Hi Carlos Yes, it is easy. However, for that one you need to have an email confirmation feature while signing up. So, when user wants to sign in with google in future then, you can check if the user having same email already exists? If existed, you can continue without creating a new user. If didn’t find email, create a new user as usual.

On Mon, 12 Jul 2021 at 2:00 pm, Carlos @.***> wrote:

Hello @sanjaya1996 https://github.com/sanjaya1996 hope you are doing fine. Have you ever thought of a feature letting a user register normally then link it with google afterwards? So like if a person does registration without google and want to use the sign in with google, is there a way to make this possible?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/sanjaya1996/proShop-EcommerceWebApp/issues/2#issuecomment-877950438, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANXTXW5T7WMWPI263MG6BJDTXJSFNANCNFSM43XWJUKA .

talmax1124 commented 3 years ago

I already have a email confirmation feature. I am using MailGun. & that second part, I have tried it several times but I had no luck. Have you done it? Can you help?

On Mon, Jul 12, 2021 at 5:35 AM Sanzay Dahal @.***> wrote:

Hi Carlos Yes, it is easy. However, for that one you need to have an email confirmation feature while signing up. So, when user wants to sign in with google in future then, you can check if the user having same email already exists? If existed, you can continue without creating a new user. If didn’t find email, create a new user as usual.

On Mon, 12 Jul 2021 at 2:00 pm, Carlos @.***> wrote:

Hello @sanjaya1996 https://github.com/sanjaya1996 hope you are doing fine. Have you ever thought of a feature letting a user register normally then link it with google afterwards? So like if a person does registration without google and want to use the sign in with google, is there a way to make this possible?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub < https://github.com/sanjaya1996/proShop-EcommerceWebApp/issues/2#issuecomment-877950438 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ANXTXW5T7WMWPI263MG6BJDTXJSFNANCNFSM43XWJUKA

.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/sanjaya1996/proShop-EcommerceWebApp/issues/2#issuecomment-878126558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOVNS3VCTK2BFYOFW2T5ER3TXKZOHANCNFSM43XWJUKA .

talmax1124 commented 3 years ago

Also, when you can, can you do a pull request on google sign in. If that pull request can include:

Thanks! @sanjaya1996

sanjaya1996 commented 3 years ago

Sorry mate, I am busy with my stuff at the moment. I can have a look at it when I am free. Cheers

On Mon, Jul 26, 2021 at 3:26 PM Carlos @.***> wrote:

Also, when you can, can you do a pull request on google sign in. If that pull request can include:

  • remove the feature to allow users to sign up with google profile.
  • Allow existing / signed up users with email to sign in with google
  • If you can, allow sign in with github and/or facebook.

Thanks! @sanjaya1996 https://github.com/sanjaya1996

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sanjaya1996/proShop-EcommerceWebApp/issues/2#issuecomment-886387691, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANXTXW6JMLD26QBUUS6ITODTZTWZ5ANCNFSM43XWJUKA .

talmax1124 commented 1 year ago

@sanjaya1996 Hey Sanjay! Hope you are doing well. If you have time, I am having trouble of Google SignOut not signing out. If you have time, it would be much appreciated.

https://github.com/talmax1124/creativeduoshop @sanjaya1996