search

sanjayg0 / feappv

FEAPpv -- free personal version of the FEAP
BSD 3-Clause "New" or "Revised" License
80 stars 44 forks source link

Variable undefined issue in pform.f #2

Closed keweili closed 5 years ago

keweili commented 5 years ago

When compiling the FEAPpv source code for the x86 platform, my student chose the "integer4" folder under the "include" folder, then we got an error saying the variables "ht1", "ht2", and "ht3" are undefined in the subroutine "pform.f". Thus, I think the file "hdata.h" should be defined as follows so that we have those three variables. 

integer           nh1,nh2,nh3,ht1,ht2,ht3                     !int 4
common /hdata/    nh1,nh2,nh3,ht1,ht2,ht3

See also https://github.com/keweili/feappv/blob/master/include/integer4/hdata.h

With this change, the 32-bit executable file worked on my machine.

sanjayg0 commented 5 years ago

Ooops. I've fixed the error. We have debated deleting integer4 altogether but have not yet made a decision. Would it not be rare for anyone (compiling code) to still be working on a 32-bit only machine?

keweili commented 5 years ago

My student had a 64-bit machine, but somehow she chose to compile the code for the x86 (Win32) platform in Visual Studio (Maybe that is the default option). Then, we found this error. After the change, it worked well, so I would keep the folder.

sanjayg0 commented 5 years ago

fyi. i put the bug fix on both the master and the devel branches.

Sanjay Govindjee, PhD, PE Horace, Dorothy, and Katherine Johnson Professor in Engineering

779 Davis Hall University of California Berkeley, CA 94720-1710

Voice: +1 510 642 6060 FAX: +1 510 643 5264 s_g@berkeley.edu http://faculty.ce.berkeley.edu/sanjay

Books:

Engineering Mechanics of Deformable Solids http://amzn.com/0199651647

Engineering Mechanics 3 (Dynamics) 2nd Edition http://amzn.com/3642537111

Engineering Mechanics 3, Supplementary Problems: Dynamics http://www.amzn.com/B00SOXN8JU

NSF NHERI SimCenter https://simcenter.designsafe-ci.org/

On 6/11/19 11:35 AM, Dr K Li wrote:

Closed #2 https://github.com/sanjayg0/feappv/issues/2.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sanjayg0/feappv/issues/2?email_source=notifications&email_token=ADIUN4Q6D4XIISTEVFYV4RDPZ7V73A5CNFSM4HW7BTZKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOR5NTGYY#event-2405118819, or mute the thread https://github.com/notifications/unsubscribe-auth/ADIUN4TKI3QBAXCKI635SFDPZ7V73ANCNFSM4HW7BTZA.